From 1861bc49e77342399adef3dd41b08e7d72615d58 Mon Sep 17 00:00:00 2001
From: Julian Stecklina <julian.stecklina@cyberus-technology.de>
Date: Mon, 3 Nov 2025 16:27:12 +0100
Subject: [PATCH] vmm: simplify receiving memory fds

... and nuke some Option<> while I was there. Given that HashMap has a
usable default and we end up passing an empty HashMap anyway, just get
rid of the Option.

On-behalf-of: SAP julian.stecklina@sap.com
Signed-off-by: Julian Stecklina <julian.stecklina@cyberus-technology.de>
---
 vmm/src/lib.rs            | 54 +++++++++++++++++----------------------
 vmm/src/memory_manager.rs |  6 ++---
 vmm/src/vm.rs             |  2 +-
 3 files changed, 28 insertions(+), 34 deletions(-)

diff --git a/vmm/src/lib.rs b/vmm/src/lib.rs
index 84db6a14c..6b1f48779 100644
--- a/vmm/src/lib.rs
+++ b/vmm/src/lib.rs
@@ -820,11 +820,30 @@ impl Vmm {
         })
     }
 
+    /// Try to receive a file descriptor from a socket. Returns the slot number and the file descriptor.
+    fn vm_receive_memory_fd(
+        socket: &mut SocketStream,
+    ) -> std::result::Result<(u32, File), MigratableError> {
+        if let SocketStream::Unix(unix_socket) = socket {
+            let mut buf = [0u8; 4];
+            let (_, file) = unix_socket.recv_with_fd(&mut buf).map_err(|e| {
+                MigratableError::MigrateReceive(anyhow!("Error receiving slot from socket: {e}"))
+            })?;
+
+            file.ok_or_else(|| MigratableError::MigrateReceive(anyhow!("Failed to receive socket")))
+                .map(|file| (u32::from_le_bytes(buf), file))
+        } else {
+            Err(MigratableError::MigrateReceive(anyhow!(
+                "Unsupported socket type"
+            )))
+        }
+    }
+
     fn vm_receive_config<T>(
         &mut self,
         req: &Request,
         socket: &mut T,
-        existing_memory_files: Option<HashMap<u32, File>>,
+        existing_memory_files: HashMap<u32, File>,
     ) -> std::result::Result<Arc<Mutex<MemoryManager>>, MigratableError>
     where
         T: Read + Write,
@@ -2126,7 +2145,7 @@ impl RequestHandler for Vmm {
 
         let mut started = false;
         let mut memory_manager: Option<Arc<Mutex<MemoryManager>>> = None;
-        let mut existing_memory_files = None;
+        let mut existing_memory_files = vec![];
         loop {
             let req = Request::read_from(&mut socket)?;
             match req.command() {
@@ -2148,7 +2167,7 @@ impl RequestHandler for Vmm {
                     memory_manager = Some(self.vm_receive_config(
                         &req,
                         &mut socket,
-                        existing_memory_files.take(),
+                        HashMap::from_iter(existing_memory_files.drain(..)),
                     )?);
                 }
                 Command::State => {
@@ -2190,34 +2209,9 @@ impl RequestHandler for Vmm {
                         continue;
                     }
 
-                    match &mut socket {
-                        SocketStream::Unix(unix_socket) => {
-                            let mut buf = [0u8; 4];
-                            let (_, file) = unix_socket.recv_with_fd(&mut buf).map_err(|e| {
-                                MigratableError::MigrateReceive(anyhow!(
-                                    "Error receiving slot from socket: {e}"
-                                ))
-                            })?;
+                    existing_memory_files.push(Self::vm_receive_memory_fd(&mut socket)?);
 
-                            if existing_memory_files.is_none() {
-                                existing_memory_files = Some(HashMap::default());
-                            }
-
-                            if let Some(ref mut existing_memory_files) = existing_memory_files {
-                                let slot = u32::from_le_bytes(buf);
-                                existing_memory_files.insert(slot, file.unwrap());
-                            }
-
-                            Response::ok().write_to(&mut socket)?;
-                        }
-                        SocketStream::Tcp(_tcp_socket) => {
-                            // For TCP sockets, we cannot transfer file descriptors
-                            warn!(
-                                "MemoryFd command received over TCP socket, which is not supported"
-                            );
-                            Response::error().write_to(&mut socket)?;
-                        }
-                    }
+                    Response::ok().write_to(&mut socket)?;
                 }
                 Command::Complete => {
                     info!("Complete Command Received");
diff --git a/vmm/src/memory_manager.rs b/vmm/src/memory_manager.rs
index 24eec5d41..1954c1711 100644
--- a/vmm/src/memory_manager.rs
+++ b/vmm/src/memory_manager.rs
@@ -995,7 +995,7 @@ impl MemoryManager {
         phys_bits: u8,
         #[cfg(feature = "tdx")] tdx_enabled: bool,
         restore_data: Option<&MemoryManagerSnapshotData>,
-        existing_memory_files: Option<HashMap<u32, File>>,
+        existing_memory_files: HashMap<u32, File>,
     ) -> Result<Arc<Mutex<MemoryManager>>, Error> {
         trace_scoped!("MemoryManager::new");
 
@@ -1030,7 +1030,7 @@ impl MemoryManager {
                 &data.guest_ram_mappings,
                 &zones,
                 prefault,
-                existing_memory_files.unwrap_or_default(),
+                existing_memory_files,
                 config.thp,
             )?;
             let guest_memory =
@@ -1263,7 +1263,7 @@ impl MemoryManager {
                 #[cfg(feature = "tdx")]
                 false,
                 Some(&mem_snapshot),
-                None,
+                Default::default(),
             )?;
 
             mm.lock()
diff --git a/vmm/src/vm.rs b/vmm/src/vm.rs
index ec455c6ba..ada1b3a14 100644
--- a/vmm/src/vm.rs
+++ b/vmm/src/vm.rs
@@ -1056,7 +1056,7 @@ impl Vm {
                     #[cfg(feature = "tdx")]
                     tdx_enabled,
                     None,
-                    None,
+                    Default::default(),
                 )
                 .map_err(Error::MemoryManager)?
             };