dsg/cloud-hypervisor
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

vhost_user_block: Return subset of config space requested

Browse source 
The spec says simply that that an empty payload should be returned on
error. Be slightly more helpful by adding a warning.

Signed-off-by: Rob Bradford <rbradford@meta.com>
This commit is contained in:
Rob Bradford 2026-01-19 08:02:29 -08:00 • committed by Rob Bradford
parent 15d34ffebb
commit 25e8e64a01
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
vhost_user_block/src/lib.rs
View file

@ -21,7 +21,7 @@ use std::{convert, io, process, result};
use block::qcow::{self, ImageType, QcowFile};
use block::{Request, VirtioBlockConfig, build_serial};
use libc::EFD_NONBLOCK;
use log::{debug, error, info};
use log::{debug, error, info, warn};
use option_parser::{OptionParser, OptionParserError, Toggle};
use thiserror::Error;
use vhost::vhost_user::Listener;
@ -395,8 +395,18 @@ impl VhostUserBackendMut for VhostUserBlkBackend {
}
}
fn get_config(&self, _offset: u32, _size: u32) -> Vec<u8> {
self.config.as_slice().to_vec()
fn get_config(&self, offset: u32, size: u32) -> Vec<u8> {
let subset = self
.config
.as_slice()
.get(offset as usize..(offset + size) as usize);
if let Some(subset) = subset {
subset.to_vec()
} else {
warn!("Invalid config offset {offset} or size {size}");
vec![]
}
}
fn set_config(&mut self, offset: u32, data: &[u8]) -> result::Result<(), io::Error> {