misc: cleanup &Arc<dyn T> -> &dyn T
Consuming `&Arc<T>` as argument is almost always an antipattern as it hides whether the callee is going to take over (shared) ownership (by .clone()) or not. Instead, it is better to consume `&dyn T` or `Arc<dyn T>` to be more explicit. This commit cleans up the code. The change is very mechanic and was very easy to implement across the code base. Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de> On-behalf-of: SAP philipp.schuster@sap.com
This commit is contained in:
parent
e295719967
commit
7536a95424
37 changed files with 121 additions and 117 deletions
|
|
@ -10,9 +10,6 @@
|
|||
//
|
||||
//
|
||||
|
||||
#[cfg(target_arch = "aarch64")]
|
||||
use std::sync::Arc;
|
||||
|
||||
use thiserror::Error;
|
||||
#[cfg(not(target_arch = "riscv64"))]
|
||||
use vm_memory::GuestAddress;
|
||||
|
|
@ -473,7 +470,7 @@ pub trait Vcpu: Send + Sync {
|
|||
#[cfg(target_arch = "aarch64")]
|
||||
fn vcpu_set_processor_features(
|
||||
&self,
|
||||
vm: &Arc<dyn crate::Vm>,
|
||||
vm: &dyn crate::Vm,
|
||||
kvi: &mut VcpuInit,
|
||||
id: u32,
|
||||
) -> Result<()>;
|
||||
|
|
|
|||
|
|
@ -2098,7 +2098,7 @@ impl cpu::Vcpu for KvmVcpu {
|
|||
#[cfg(target_arch = "aarch64")]
|
||||
fn vcpu_set_processor_features(
|
||||
&self,
|
||||
vm: &Arc<dyn crate::Vm>,
|
||||
vm: &dyn crate::Vm,
|
||||
kvi: &mut crate::VcpuInit,
|
||||
id: u32,
|
||||
) -> cpu::Result<()> {
|
||||
|
|
|
|||
|
|
@ -1306,7 +1306,7 @@ impl cpu::Vcpu for MshvVcpu {
|
|||
#[cfg(target_arch = "aarch64")]
|
||||
fn vcpu_set_processor_features(
|
||||
&self,
|
||||
_vm: &Arc<dyn crate::Vm>,
|
||||
_vm: &dyn crate::Vm,
|
||||
_kvi: &mut crate::VcpuInit,
|
||||
_id: u32,
|
||||
) -> cpu::Result<()> {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue