From 7d6c450cee7df7a580e665b4c942906c3f179262 Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Mon, 20 Oct 2025 12:12:04 +0100 Subject: [PATCH] virtio-devices: pci_common_config: Remove warning for feature pages > 2 The virtio spec defines the feature bit range and 4 x 32-bit pages. However no features are currently defined with bits > 63. However Linux has now started acking features in those higher pages. Since this is harmless (we drop the acks to those feature pages) and quietly return 0 for available features in those higher pages this warning can be removed. Fixes: #7414 Signed-off-by: Rob Bradford --- virtio-devices/src/transport/pci_common_config.rs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/virtio-devices/src/transport/pci_common_config.rs b/virtio-devices/src/transport/pci_common_config.rs index dcf5891f1..0680b4a30 100644 --- a/virtio-devices/src/transport/pci_common_config.rs +++ b/virtio-devices/src/transport/pci_common_config.rs @@ -330,11 +330,6 @@ impl VirtioPciCommonConfig { let mut locked_device = device.lock().unwrap(); locked_device .ack_features(u64::from(value) << (self.driver_feature_select * 32)); - } else { - warn!( - "invalid ack_features (page {}, value 0x{:x})", - self.driver_feature_select, value - ); } } 0x20 => self.with_queue_mut(queues, |q| q.set_desc_table_address(Some(value), None)),