dsg/cloud-hypervisor
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

misc: arch/riscv64: streamline #[source] and Error

Browse source 
This streamlines the code base to follow best practices for
error handling in Rust: Each error struct implements
std::error::Error (most due via thiserror::Error derive macro)
and sets its source accordingly.

This allows future work that nicely prints the error chains,
for example.

So far, the convention is that each error prints its
sub error as part of its Display::fmt() impl.

Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
On-behalf-of: SAP philipp.schuster@sap.com
This commit is contained in:
Philipp Schuster 2025-05-19 09:49:51 +02:00 • committed by Rob Bradford
parent d1a406143d
commit a212343908
17 changed files with 179 additions and 174 deletions
Download patch file Download diff file Expand all files Collapse all files

9
pci/src/msix.rs
View file

@ -8,6 +8,7 @@ use std::{io, result};
use byteorder::{ByteOrder, LittleEndian};
use serde::{Deserialize, Serialize};
use thiserror::Error;
use vm_device::interrupt::{
InterruptIndex, InterruptSourceConfig, InterruptSourceGroup, MsiIrqSourceConfig,
};
@ -27,12 +28,14 @@ const MSIX_ENABLE_MASK: u16 = (1 << MSIX_ENABLE_BIT) as u16;
pub const MSIX_TABLE_ENTRY_SIZE: usize = 16;
pub const MSIX_CONFIG_ID: &str = "msix_config";
#[derive(Debug)]
#[derive(Error, Debug)]
pub enum Error {
/// Failed enabling the interrupt route.
EnableInterruptRoute(io::Error),
#[error("Failed enabling the interrupt route: {0}")]
EnableInterruptRoute(#[source] io::Error),
/// Failed updating the interrupt route.
UpdateInterruptRoute(io::Error),
#[error("Failed updating the interrupt route: {0}")]
UpdateInterruptRoute(#[source] io::Error),
}
#[derive(Debug, Clone, Serialize, Deserialize, Eq, PartialEq)]