From b708db393dbde692803ebe1c65fc22c600b530e3 Mon Sep 17 00:00:00 2001 From: Ruoqing He Date: Fri, 18 Oct 2024 17:52:47 +0800 Subject: [PATCH] misc: Remove redundant pub keyword of helper functions Functions marked as `pub` in test module need to be documented. Since these are literally helper functions and there is no need to be `pub`, remove these `pub` keywords. Signed-off-by: Ruoqing He --- rate_limiter/src/group.rs | 4 ++-- rate_limiter/src/lib.rs | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/rate_limiter/src/group.rs b/rate_limiter/src/group.rs index 336640226..6a070b72a 100644 --- a/rate_limiter/src/group.rs +++ b/rate_limiter/src/group.rs @@ -309,12 +309,12 @@ pub(crate) mod tests { use crate::{TokenBucket, TokenType, REFILL_TIMER_INTERVAL_MS}; impl RateLimiterGroupHandle { - pub fn bandwidth(&self) -> Option { + fn bandwidth(&self) -> Option { let guard = self.inner.rate_limiter.inner.lock().unwrap(); guard.bandwidth.clone() } - pub fn ops(&self) -> Option { + fn ops(&self) -> Option { let guard = self.inner.rate_limiter.inner.lock().unwrap(); guard.ops.clone() } diff --git a/rate_limiter/src/lib.rs b/rate_limiter/src/lib.rs index b46800ae6..9fc12ddd4 100644 --- a/rate_limiter/src/lib.rs +++ b/rate_limiter/src/lib.rs @@ -544,7 +544,8 @@ pub(crate) mod tests { } // After a restore, we cannot be certain that the last_update field has the same value. - pub fn partial_eq(&self, other: &TokenBucket) -> bool { + #[allow(dead_code)] + fn partial_eq(&self, other: &TokenBucket) -> bool { (other.capacity() == self.capacity()) && (other.one_time_burst() == self.one_time_burst()) && (other.refill_time_ms() == self.refill_time_ms()) @@ -553,12 +554,12 @@ pub(crate) mod tests { } impl RateLimiter { - pub fn bandwidth(&self) -> Option { + fn bandwidth(&self) -> Option { let guard = self.inner.lock().unwrap(); guard.bandwidth.clone() } - pub fn ops(&self) -> Option { + fn ops(&self) -> Option { let guard = self.inner.lock().unwrap(); guard.ops.clone() }