There don't appear to be any new clippy warnings, and this is the version of Rust that Android is now using: b/303252546. Work for the next version is tracked in b/310977762. This doesn't have any particular features I'm looking for (async traits only come in 1.75.0). I'm not particularly attached to this change. If it's easy to upgrade the container though, we could ensure no new clippy warnings appear. Android rust versions appear here: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/rust/linux-x86/ Also not sure what the ChromeOS release schedule is. Release docs: https://releases.rs/docs/1.73.0/ Test: tools/dev_container --clean bash -c "rustc --version && tools/presubmit clippy" Change-Id: I2d3010c3032053709f0c0beb7dcbe2b80d782415 Reviewed-on: https://chromium-review.googlesource.com/c/crosvm/crosvm/+/5201659 Reviewed-by: Daniel Verkamp <dverkamp@chromium.org> Commit-Queue: Dennis Kempin <denniskempin@google.com> |
||
|---|---|---|
| .. | ||
| Dockerfile | ||
| Makefile | ||
| README.md | ||
| version | ||
Dev Container
This directory contains the dev container used by developers locally as well as the crosvm CI infrastructure.
The container is defined by tools/impl/dev_container/Dockerfile, which will primarily run the
tools/install* scripts to install all dependencies.
To include new dependencies in the container, modify the corresponding install script and rebuild the container with:
make -C tools/impl/dev_container crosvm_dev
This will make the image available for testing locally with tools/dev_container. You may have to
stop the previous container to pick up the new image tools/dev_container --stop.
To upload the new version of the container, uprev the version file and run;
make -C tools/impl/dev_container upload
You need to be a Googler to be able to do so. See go/crosvm/infra for access control and authenticate via:
gcloud auth configure-docker gcr.io