dsg/mesa
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs: do not generate redirects on error

Browse source 
The build-finished event is also triggered when there's an error. I
somehow got the second argument wrong, and ended up ignoring the case.
This can lead to new exceptions being thrown due to missing files, that
ends up hiding the real problem.

Fixes: 64a4ba9e1c ("docs: add an extension to generate redirects")
Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10407>
This commit is contained in:
Erik Faye-Lund 2021-04-22 13:46:41 +02:00 • committed by Marge Bot
parent 5a1675a030
commit 2736370294
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/_exts/redirects.py
View file

@ -6,8 +6,8 @@ def create_redirect(dst):
tpl = '<html><head><meta http-equiv="refresh" content="0; url={0}"><script>window.location.replace("{0}")</script></head></html>'
return tpl.format(dst)
def create_redirects(app, docname):
if not app.builder.name == 'html':
def create_redirects(app, exception):
if exception is not None or not app.builder.name == 'html':
return
for src, dst in app.config.html_redirects:
path = os.path.join(app.outdir, '{0}.html'.format(src))