dsg/mesa
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

egl/surfaceless,device: Support RGB[A]16_UNORM formats for pbuffers.

Browse source 
Use the EGL_EXT_config_select_group extension to put these 16 bpc
unorm formats into a lower priority config select group 1, so they
don't get preferably chosen by default by eglChooseConfig(), but must
be explicitely requested by client applications which really need the
high color precision of these 64 bpp formats and are happy to pay the
potential performance impact.

Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38588>
This commit is contained in:
Mario Kleiner 2025-11-29 02:16:57 +00:00 • committed by Marge Bot
parent 171f484eb0
commit 82e12d3d83
1 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/egl/drivers/dri2/egl_dri2.c
View file

@ -84,6 +84,8 @@
static const enum pipe_format dri2_pbuffer_visuals[] = {
PIPE_FORMAT_R16G16B16A16_FLOAT,
PIPE_FORMAT_R16G16B16X16_FLOAT,
PIPE_FORMAT_R16G16B16A16_UNORM,
PIPE_FORMAT_R16G16B16X16_UNORM,
PIPE_FORMAT_B10G10R10A2_UNORM,
PIPE_FORMAT_B10G10R10X2_UNORM,
PIPE_FORMAT_BGRA8888_UNORM,
@ -482,6 +484,7 @@ dri2_add_pbuffer_configs_for_visuals(_EGLDisplay *disp)
for (unsigned i = 0; dri2_dpy->driver_configs[i] != NULL; i++) {
struct dri2_egl_config *dri2_conf;
EGLint config_group = 0;
struct gl_config *gl_config =
(struct gl_config *) dri2_dpy->driver_configs[i];
int idx = dri2_pbuffer_visual_index(gl_config->color_format);
@ -489,8 +492,20 @@ dri2_add_pbuffer_configs_for_visuals(_EGLDisplay *disp)
if (idx == -1)
continue;
/* Put the 16 bpc rgb[a] unorm formats into a lower priority EGL config
* group 1, so they don't get preferably chosen by eglChooseConfig().
*/
if (util_format_is_unorm16(util_format_description(gl_config->color_format)))
config_group = 1;
const EGLint attr_list[] = {
EGL_CONFIG_SELECT_GROUP_EXT,
config_group,
EGL_NONE,
};
dri2_conf = dri2_add_config(disp, dri2_dpy->driver_configs[i],
EGL_PBUFFER_BIT, NULL);
EGL_PBUFFER_BIT, attr_list);
if (dri2_conf)
format_count[idx]++;
}