dsg/mesa
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

panvk: Compile shaders in pipeline stage order

Browse source 
Reviewed-by: Lorenzo Rossi <lorenzo.rossi@collabora.com>
Acked-by: Eric R. Smith <eric.smith@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38681>
This commit is contained in:
Faith Ekstrand 2025-12-03 21:35:21 -05:00 • committed by Marge Bot
parent 6f11a4028f
commit aad690fd9a
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/panfrost/vulkan/panvk_vX_shader.c
View file

@ -1518,10 +1518,8 @@ compile_shaders(struct vk_device *vk_dev, uint32_t shader_count,
use_static_noperspective = true;
}
/* Vulkan runtime passes us shaders in stage order, so the FS will always
* be last if it exists. Iterate shaders in reverse order to ensure FS is
* processed before VS. */
for (i = shader_count - 1; i >= 0; i--) {
/* Vulkan runtime passes us shaders in stage order */
for (i = 0; i < shader_count; i++) {
const uint32_t *noperspective_varyings_ptr =
use_static_noperspective ? &noperspective_varyings : NULL;
result =
@ -1542,11 +1540,11 @@ compile_shaders(struct vk_device *vk_dev, uint32_t shader_count,
err_cleanup:
/* Clean up all the shaders before this point */
for (int32_t j = shader_count - 1; j > i; j--)
for (int32_t j = 0; j < i; j++)
panvk_shader_destroy(&dev->vk, shaders_out[j], pAllocator);
/* Clean up all the NIR from this point */
for (int32_t j = i; j >= 0; j--)
for (int32_t j = i; j < shader_count; j++)
ralloc_free(infos[j].nir);
/* Memset the output array */