From f1411b045049148143f6139275296b1e9e73b5e3 Mon Sep 17 00:00:00 2001 From: Matias Ezequiel Vara Larsen Date: Fri, 10 Oct 2025 10:30:13 +0200 Subject: [PATCH] can: make features values conforming to the virtio spec Fix the values of VIRTIO_CAN_F_RTR_FRAMES and VIRTIO_CAN_F_LATE_TX_ACK to be conforming to the virtio spec and the driver (see comments in https://lkml.org/lkml/2025/9/11/1615). Signed-off-by: Matias Ezequiel Vara Larsen --- vhost-device-can/CHANGELOG.md | 1 + vhost-device-can/src/virtio_can.rs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/vhost-device-can/CHANGELOG.md b/vhost-device-can/CHANGELOG.md index 6c84888..f92a693 100644 --- a/vhost-device-can/CHANGELOG.md +++ b/vhost-device-can/CHANGELOG.md @@ -6,6 +6,7 @@ ### Changed ### Fixed +- [[#888]](https://github.com/rust-vmm/vhost-device/pull/888) can: make features values conforming to the virtio spec ### Deprecated diff --git a/vhost-device-can/src/virtio_can.rs b/vhost-device-can/src/virtio_can.rs index 768dc12..1ff422c 100644 --- a/vhost-device-can/src/virtio_can.rs +++ b/vhost-device-can/src/virtio_can.rs @@ -42,9 +42,9 @@ pub(crate) const VIRTIO_CAN_RX: u16 = 0x0101; pub const VIRTIO_CAN_F_CAN_CLASSIC: u16 = 0; pub const VIRTIO_CAN_F_CAN_FD: u16 = 1; pub const VIRTIO_CAN_S_CTRL_BUSOFF: u16 = 2; /* Controller BusOff */ +pub const VIRTIO_CAN_F_RTR_FRAMES: u16 = 2; #[allow(dead_code)] -pub const VIRTIO_CAN_F_LATE_TX_ACK: u16 = 2; -pub const VIRTIO_CAN_F_RTR_FRAMES: u16 = 3; +pub const VIRTIO_CAN_F_LATE_TX_ACK: u16 = 3; /// Possible values of the status field pub const VIRTIO_CAN_RESULT_OK: u8 = 0x0;