vhost-user-backend: SET_VRING_KICK not disabling the vring
This was introduced in 7f326dd314, but
doesn't work with qemu versions < 7.2. SET_FEATURES is received before
SET_VRING_KICK, we will enable the vrings in set_features() and disabled
them later in set_vring_kick().
Currently, the libvhostuser in qemu disables the vring upon receiving
RESET_OWNER, but that message is currently deprecated. There is not a
sane place to disable the vring, since according to the spec we can only
do that upon receiving RESET_OWNER (deprecated), RESET_DEVICE (currently
not supported in this crate), and SET_VRING_ENABLE.
The current state of the vhost-user spec is a mess, we need a more
formal spec that just a wall of english.
Signed-off-by: German Maglione <gmaglione@redhat.com>
This commit is contained in:
parent
71821bd979
commit
2bba1c8ab1
1 changed files with 0 additions and 1 deletions
|
|
@ -203,7 +203,6 @@ where
|
|||
}
|
||||
}
|
||||
|
||||
vring.set_enabled(false);
|
||||
vring.set_queue_ready(true);
|
||||
|
||||
Ok(())
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue