From bc6b4cc59f4594004a3ba5e1ccdc135ec005f362 Mon Sep 17 00:00:00 2001 From: Matej Hrica Date: Wed, 28 Aug 2024 11:44:03 +0200 Subject: [PATCH] backend_req::tests: Extract test setup to a function Extract creating a backend and a frontend from a socketpair to a utility function. Signed-off-by: Matej Hrica --- vhost/src/vhost_user/backend_req.rs | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/vhost/src/vhost_user/backend_req.rs b/vhost/src/vhost_user/backend_req.rs index 19c5c27..ce83839 100644 --- a/vhost/src/vhost_user/backend_req.rs +++ b/vhost/src/vhost_user/backend_req.rs @@ -182,10 +182,16 @@ mod tests { use super::*; + fn frontend_backend_pair() -> (Endpoint>, Backend) { + let (p1, p2) = UnixStream::pair().unwrap(); + let backend = Backend::from_stream(p1); + let frontend = Endpoint::>::from_stream(p2); + (frontend, backend) + } + #[test] fn test_backend_req_set_failed() { - let (p1, _p2) = UnixStream::pair().unwrap(); - let backend = Backend::from_stream(p1); + let (_, backend) = frontend_backend_pair(); assert!(backend.node().error.is_none()); backend.set_failed(libc::EAGAIN); @@ -194,8 +200,7 @@ mod tests { #[test] fn test_backend_req_send_failure() { - let (p1, _) = UnixStream::pair().unwrap(); - let backend = Backend::from_stream(p1); + let (_, backend) = frontend_backend_pair(); backend.set_failed(libc::ECONNRESET); backend @@ -209,9 +214,7 @@ mod tests { #[test] fn test_backend_req_recv_negative() { - let (p1, p2) = UnixStream::pair().unwrap(); - let backend = Backend::from_stream(p1); - let mut frontend = Endpoint::>::from_stream(p2); + let (mut frontend, backend) = frontend_backend_pair(); let len = mem::size_of::(); let mut hdr = VhostUserMsgHeader::new(