dsg/vmsilo
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor: remove dead _generatedGuestConfig option

Browse source 
The _generatedGuestConfig option was declared and read but never set by
any module, making it always evaluate to []. Remove the declaration and
simplify getEffectiveGuestConfig to read only from netvmInjections.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Davíð Steinn Geirsson 2026-03-22 14:18:20 +00:00
parent 033a2b7375
commit b1bb3ad7cd
2 changed files with 1 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
modules/lib/vm-config.nix
View file

@ -26,8 +26,7 @@ let
getEffectiveInterfaces = helpers.getEffectiveInterfaces cfg._internal.netvmInjections;
getEffectiveGuestConfig =
vm: vm._generatedGuestConfig ++ (cfg._internal.netvmInjections.${vm.name}.guestConfig or [ ]);
getEffectiveGuestConfig = vm: cfg._internal.netvmInjections.${vm.name}.guestConfig or [ ];
userUid = config.users.users.${cfg.user}.uid;
userGid = config.users.groups.${config.users.users.${cfg.user}.group}.gid;

6
modules/options.nix
View file

@ -809,12 +809,6 @@ let
description = "Per-VM cloud-hypervisor configuration overrides.";
};
_generatedGuestConfig = lib.mkOption {
type = lib.types.listOf lib.types.deferredModule;
default = [ ];
internal = true;
description = "Auto-generated guest NixOS modules (e.g., nftables for netvms). Do not set manually.";
};
};
}
);